Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] Make Dart repos sound null safe #49169

Closed
26 tasks done
devoncarew opened this issue Jun 3, 2022 · 3 comments
Closed
26 tasks done

[meta] Make Dart repos sound null safe #49169

devoncarew opened this issue Jun 3, 2022 · 3 comments
Assignees
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...).

Comments

@devoncarew
Copy link
Member

devoncarew commented Jun 3, 2022

This is a meta issue used to track the progress on making various Dart repos sound null safe. This must happen prior to null safety becoming the only supported mode.

Published packages

Non-published SDK packages

Info

Packages listed here should either be converted to null safety (indicated by having a lower SDK bounds of 2.12), and make sure that no files are excluded from null safety (no files have a language comment of // @dart=2.7, // @dart=2.8, // @dart=2.9, // @dart=2.10, or // @dart=2.11).

Note that we're only trying to find unintentional file opt-outs above - null safety conversions that weren't quite finished.

If the opt-out is intentional - there in order to test the opt-out handling and / or pre-null safe behavior - please update / edit / close the issue as appropriate. Additionally, consider adding a token on the line before the opt-out - // null_safety_optout_testing. This will allow tools to ignore the opt-out when looking for unmigrated files, and, allow us to find and remove all null safe testing opt-outs at a later date. For cases like these, the full opt-out may then look something like:

// null_safety_optout_testing
// @dart=2.10
@devoncarew devoncarew added the area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). label Jun 3, 2022
This was referenced Jun 3, 2022
@natebosch
Copy link
Member

Some of these are intentional. We run tests which are not null safe in some packages to validate some specific unsound mode behavior. A bunch are in files that are named with a suffix of _opt_out_test.dart.
Should we try to find a convention for this and exclude it from the search?

@devoncarew
Copy link
Member Author

This was likely a one-shot search. If we need to update the grep logic to be more accurate, we certainly can. But it may be enough to just update the individual issues - reduce the hits found or close the issue entirely.

@mit-mit
Copy link
Member

mit-mit commented Mar 6, 2023

All done 🥳

@mit-mit mit-mit closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...).
Projects
None yet
Development

No branches or pull requests

3 participants