Found 23 files excluded from sound null safety

[devoncarew]

Found 23 files excluded from sound null safety:

test/rules/null_closures_test.dart:23:// @dart=2.9
test/rules/null_closures_test.dart:31:// @dart=2.9
test/rules/null_closures_test.dart:41:// @dart=2.9
test/rules/null_closures_test.dart:51:// @dart=2.9
test/rules/prefer_collection_literals_test.dart:23:// @dart=2.9    
test/rules/prefer_collection_literals_test.dart:32:// @dart=2.9    
test/rules/prefer_collection_literals_test.dart:41:// @dart=2.9    
test_data/integration/always_require_non_null_named_parameters/lib.dart:5:// @dart=2.9
test_data/integration/avoid_private_typedef_functions/lib.dart:5:// @dart=2.9
test_data/integration/avoid_private_typedef_functions/part.dart:5:// @dart=2.9
test_data/integration/cancel_subscriptions/cancel_subscriptions.dart:5:// @dart=2.9
test_data/integration/close_sinks/src/a.dart:5:// @dart=2.9
test_data/integration/only_throw_errors/only_throw_errors.dart:5:// @dart=2.9
test_data/integration/overridden_fields/src/a.dart:5:// @dart=2.9
test_data/integration/overridden_fields/src/b.dart:5:// @dart=2.9
test_data/integration/public_member_api_docs/test/b.dart:5:// @dart=2.9
test_data/integration/use_build_context_synchronously/lib/unmigrated.dart:5:// @dart=2.9
test_data/rules/always_require_non_null_named_parameters.dart:7:// @dart=2.9
test_data/rules/avoid_init_to_null.dart:5:// @dart=2.9
test_data/rules/avoid_returning_null.dart:7:// @dart=2.9
test_data/rules/avoid_returning_null_for_future.dart:7:// @dart=2.8
test_data/rules/prefer_bool_in_asserts.dart:5:// @dart=2.9
test_data/rules/void_checks.dart:7:// @dart=2.9

See dart-lang/sdk#49169 for more context.

[devoncarew]

Some of the above look like exclusions test nnbd opt-outs, but others looks like excluded tests (which should be converted over to null safe).

[pq]

Thanks for this!

others looks like excluded tests

From a quick look, these all appear to be exclusions in test data. The ones in the test/ directory are in strings, for example:

  test_list_firstWhere() async {
    await assertNoDiagnostics(r'''
// @dart=2.9
f() => <int>[2, 4, 6].firstWhere((e) => e.isEven, orElse: () => null);
''');
  }

in https://github.com/dart-lang/linter/blob/master/test/rules/null_closures_test.dart#L23

is defined in pre-nnnbd NullClosuresPreNNBDTest.

Given how many folks internally haven't migrated I think there's value in continuing to test these cases.

I'll go ahead and close this as per dart-lang/sdk#49169 but feel free to re-open if you want to discuss some more.

Again, thanks!