[swift2objc] Filtering Support #1730
Conversation
| /// | ||
| /// APIs can be filtered by name | ||
| /// | ||
| /// TODO: Add `excludeAll` option to exclude all or include all declarations |
There was a problem hiding this comment.
I don't think that's necessary. People can just set filter = (_) => false.
| /// APIs can be filtered by name | ||
| /// | ||
| /// TODO: Add `excludeAll` option to exclude all or include all declarations | ||
| final bool Function(Declaration declaration)? filter; |
There was a problem hiding this comment.
The name and documentation don't really make it clear whether this function should return true or false to include the given declaration. Maybe rename it include or shouldInclude. Also, make it non-null and then set a default in the constructor.
| @@ -43,6 +43,16 @@ ReferredType _parseVariableType( | |||
| ) { | |||
| final subHeadings = propertySymbolJson['names']['subHeading']; | |||
|
|
|||
| // if subheadings have text that contain sets of parentheses and arrows | |||
There was a problem hiding this comment.
This looks like closure stuff. Remove it from this PR.
| outputFile: Uri.file(actualOutputFile), | ||
| tempDir: Directory(thisDir).uri, | ||
| preamble: '// Test preamble text', | ||
| filter: (declaration) => false, |
There was a problem hiding this comment.
This test would be a bit better if you filtered some specific declarations. Try adding a few more classes, methods, globals, top level functions etc, and filter some of them but not all of them.
There was a problem hiding this comment.
Oh, also, can you add a method that is included by the filter, but refers to a class that is not included? What should happen in that case?
This Pull Request is to add filtering support to the swiftgen tool.
ConfigMore information can be found here: #1394