Update all popularity when updating the search snapshot. (#7169)

dart-lang · Nov 9, 2023 · 329339d · 329339d
1 parent e0de45e
commit 329339d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/app/lib/search/backend.dart b/app/lib/search/backend.dart
@@ -197,7 +197,15 @@ class SearchBackend {
       futures.clear();
 
       if (claim.valid && lastUploadedSnapshotTimestamp != snapshot.updated) {
+        // Updates the normalized like score across all the packages.
         snapshot.updateLikeScores();
+
+        // Updates all popularity values to the currently cached one, otherwise
+        // only updated package would have been on their new values.
+        for (final d in snapshot.documents!.values) {
+          d.popularityScore = popularityStorage.lookup(d.package);
+        }
+
         await _snapshotStorage.uploadDataAsJsonMap(snapshot.toJson());
         lastUploadedSnapshotTimestamp = snapshot.updated!;
       }

diff --git a/app/lib/search/search_service.dart b/app/lib/search/search_service.dart
@@ -78,7 +78,7 @@ class PackageDocument {
   double? likeScore;
 
   /// The normalized score between [0.0-1.0] (1.0 being the most popular package).
-  final double? popularityScore;
+  double? popularityScore;
 
   final int grantedPoints;
   final int maxPoints;