Skip to content

Commit

Permalink
Comment on why the other events are filtered out.
Browse files Browse the repository at this point in the history
  • Loading branch information
isoos committed Dec 12, 2023
1 parent 0f67ffb commit bd695f8
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions app/lib/service/entrypoint/_isolate.dart
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,8 @@ class IsolateRunner {
_isolates.add(isolate);
unawaited(isolate.done.then((_) async {
_isolates.remove(isolate);
// The `done` callback may happen on schedule renewal, instance shutdown,
// or unexpected exits. We only need to propagate the issue on the later.
if (!_closing && !isolate.markedForRenew) {
throw Exception('$id exited unexpectedly.');
}
Expand Down

0 comments on commit bd695f8

Please sign in to comment.