Remove obsolete task scheduler for search. (#6794)

dart-lang · Jun 28, 2023 · ea441d2 · ea441d2
1 parent 0abd33e
commit ea441d2
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 64 deletions.
diff --git a/app/lib/search/updater.dart b/app/lib/search/updater.dart
@@ -92,11 +92,10 @@ class IndexUpdater implements TaskRunner {
   }
 
   /// Starts the scheduler to update the package index.
-  void runScheduler({required Stream<Task> manualTriggerTasks}) {
+  void runScheduler() {
     final scheduler = TaskScheduler(
       this,
       [
-        ManualTriggerTaskSource(manualTriggerTasks),
         DatastoreHeadTaskSource(
           _db,
           TaskSourceModel.package,

diff --git a/app/lib/service/entrypoint/search.dart b/app/lib/service/entrypoint/search.dart
@@ -17,8 +17,6 @@ import '../../shared/env_config.dart';
 import '../../shared/handler_helpers.dart';
 import '../../shared/popularity_storage.dart';
 import '../../shared/scheduler_stats.dart';
-import '../../shared/task_client.dart';
-import '../../shared/task_scheduler.dart';
 import '../../tool/neat_task/pub_dev_tasks.dart';
 
 import '_isolate.dart';
@@ -54,9 +52,6 @@ Future _main(FrontendEntryMessage message) async {
 
   await popularityStorage.start();
 
-  final ReceivePort taskReceivePort = ReceivePort();
-  registerTaskSendPort(taskReceivePort.sendPort);
-
   // Don't block on init, we need to serve liveliness and readiness checks.
   scheduleMicrotask(() async {
     await dartSdkMemIndex.start();
@@ -68,7 +63,7 @@ Future _main(FrontendEntryMessage message) async {
       rethrow;
     }
 
-    indexUpdater.runScheduler(manualTriggerTasks: taskReceivePort.cast<Task>());
+    indexUpdater.runScheduler();
   });
 
   await runHandler(_logger, searchServiceHandler);

diff --git a/app/lib/shared/task_client.dart b/app/lib/shared/task_client.dart
diff --git a/app/lib/shared/task_scheduler.dart b/app/lib/shared/task_scheduler.dart
@@ -26,16 +26,6 @@ abstract class TaskSource {
   Stream<Task> startStreaming();
 }
 
-/// Tasks coming from through the isolate's receivePort, originating from a
-/// HTTP handler that received a ping after a new upload.
-class ManualTriggerTaskSource implements TaskSource {
-  final Stream<Task> _taskReceivePort;
-  ManualTriggerTaskSource(this._taskReceivePort);
-
-  @override
-  Stream<Task> startStreaming() => _taskReceivePort;
-}
-
 /// Schedules and executes tasks.
 ///
 /// The execution of the tasks are prioritized in the order of the task sources: