Upgrade package:puppeteer in pkg/pub_integration #7211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
isoos
commented
Nov 21, 2023
•
isoos
commented
- Fixes upgrade package:puppeteer in pkg/pub_integration #7199.
- Apparently the issue was local to my environment, I needed to upgrade my chrome instance.
- Also added a fix to reduce CI flakes by waiting for layout to be updated (different) for the specified elements.
isoos
force-pushed
the
upgrade-puppeteer
branch
2 times, most recently
from
4f014e9
to
57ceef1
Compare
isoos
force-pushed
the
upgrade-puppeteer
branch
from
57ceef1
to
b7f565d
Compare
sigurdm
reviewed
Nov 30, 2023
| @@ -187,6 +192,39 @@ extension PubPageExt on Page { | |||
| await _waitForModelHidden(); | |||
| } | |||
|
|
|||
| /// Waits until the given selectors are visible and their UI top-left position | |||
There was a problem hiding this comment.
Sounds completely crazy that we have to make a hack like this. Should this not be built into the framework somehow?
There was a problem hiding this comment.
I think this is a side-effect of the material widgets we are using. I've never seen similar issue with regular HTML checkboxes.
sigurdm
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.