Bucket config + initialization for API JSON exporter. #7238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
isoos
commented
Dec 1, 2023
isoos
commented
- The initialization and use only happens if the bucket is configured, which we are not yet doing for neither staging nor prod.
- The ongoing export runs in one of the analyzer instances as a separate isolate.
- The daily update of name completion and the weekly cleanup runs on the analyzer as part of the other periodic tasks.
jonasfj
approved these changes
Dec 5, 2023
|
|
||
| Future _apiExporterMain(EntryMessage message) async { | ||
| message.protocolSendPort.send(ReadyMessage()); | ||
| await popularityStorage.start(); |
There was a problem hiding this comment.
why popularityStorage.start();`?
There was a problem hiding this comment.
We don't need it yet, but we may if/when we export endpoints with popularity scores. It felt better to include it so we won't forget about it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.