Foldable widgets: added keyboard navigation, removed (broken) animation. #7336
Conversation
| e.preventDefault(); | ||
| await toggle(); | ||
| }); | ||
| h.onKeyDown.where((e) => e.key == 'Enter').listen((e) async { |
There was a problem hiding this comment.
I was wondering about this, whether we should add Space or not, and if we add it here, we should add it at other places too. Created a new issue to track it: #7341
| num scrollDiff = 0; | ||
| if (scrollContainer != null) { | ||
| // Wait one animation frame before measurements. |
There was a problem hiding this comment.
Not sure I understand all this scrolling logic...
Do we really need it?
There was a problem hiding this comment.
This is for the mobile view: when the navigation menu is at the bottom, and it is clicked, there is no indication that something has been displayed under the fold. Scrolling to it makes the new content visible.
There was a problem hiding this comment.
Can we just use scrollIntoView?
There was a problem hiding this comment.
I think we have tried it and it worked with full-page elements, but had issues with embedded-scroll of the navigation. It may be worth to re-evaluate it again, a lot of time has passed since.
There was a problem hiding this comment.
#7342 to track it separately
|
I'd like to see this on staging also |
visibility: hiddenandtransform: scaleYalternatives, but they were not working as expected or were breaking accessibility again).