Refactored dartdoc post-processing. #7553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
isoos
commented
Mar 12, 2024
isoos
commented
- Maybe consider different timeouts for analysis #7430
- decreased dartdoc timeout as even large packages can manage to get it done within 30 minutes
- dart post-processing may be skipped entirely based on the time spent in pana analysis
- processing of files and archive building is in separate isolates, running in parallel
sigurdm
reviewed
Mar 12, 2024
|
|
||
| _log.info('Finished .tar.gz archive'); | ||
| await Future.wait([ |
There was a problem hiding this comment.
What a shame Isolate.run doesn't support timeouts or some easy way to kill the isolate after a timeout...
Maybe we have to write that abstraction ourselves.
There was a problem hiding this comment.
Oh, I can add a timer that just kills the isolate from the inside... maybe in a follow-up PR.
There was a problem hiding this comment.
...Unless we have sync tasks blocking inside the isolate...
There was a problem hiding this comment.
Maybe we don't need this at all, as worst case the parent process will kill pana_wrapper after the set timeout.
sigurdm
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.