New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated analysis pending logic #7566

Merged

isoos merged 1 commit into dart-lang:master from isoos:pending

Mar 21, 2024

Collaborator

isoos commented Mar 18, 2024

Fixes When analysis times out, and is killed, but a log.txt has been uploaded, we should show it. #7563.
isSkipped renamed to hasNoTaskStatus for better clarity.
showPending is updated to also consider hasNoTaskStatus when checking for isLatestStable.
The log.txt link is shown also when it has failed (or aborted).


          Updated analysis pending logic

b494bc0

isoos requested review from jonasfj and sigurdm

March 18, 2024 13:22

sigurdm approved these changes

View reviewed changes

szakarias approved these changes

View reviewed changes

isoos merged commit aeea2ca into dart-lang:master

31 checks passed

isoos deleted the pending branch

March 21, 2024 08:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet