Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate inset colors (e.g. code and tab background) #8081

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Sep 27, 2024

  • Partial reimplementation of New naming scheme for theme roles + migrating some background colors. #8064, only changing one color role at a time, doing with the inset background.
  • Insets are items that are integral part of the regular page flow, like code blocks, tabs, even badges.
  • color changes:
    • the light theme's simple badge's color goes from #f0f0f0 to #f5f5f7 (this is the background of the [unknown platforms] badge) - the dark theme already used the inset color as a background
    • the dark theme's color changes from #474747 to #41424c (anchor black) as one of the closest named color
    • fixed --pub-sort_control_hover-background-color as it should use the hover background instead of the inset background (planned in a subsequent PR)

@isoos
Copy link
Collaborator Author

isoos commented Sep 27, 2024

Note: this has been pushed to staging.

@isoos
Copy link
Collaborator Author

isoos commented Sep 27, 2024

Note: I think the new Flutter website is planning to use rgba(185, 174, 0, 0.2) as the dark theme code block background, but I found it way too bright, and rather keeping the current version for now. We may revisit this later.

@sigurdm
Copy link
Contributor

sigurdm commented Sep 27, 2024

Note: I think the new Flutter website is planning to use rgba(185, 174, 0, 0.2) as the dark theme code block background, but I found it way too bright, and rather keeping the current version for now. We may revisit this later.

cc @parlough

@isoos isoos merged commit ef90118 into dart-lang:master Sep 30, 2024
33 checks passed
@isoos isoos deleted the css-inset branch September 30, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants