Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix automatic status on resolving an appeal. #8093

Closed
wants to merge 1 commit into from
Closed

Fix automatic status on resolving an appeal. #8093

wants to merge 1 commit into from

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Oct 1, 2024

  • Previous behavior (with bad test): (1) package gets moderated (2) appeal is filed (3) moderation is reverted (4) appeal is closed with automatic status: moderation-upheld. The correct status for this is moderation-reverted.
  • The new behavior merged the actions from the original (appealed) ModerationCase and the current (appeal) ModerationCase and calculates the cumulative effect. If there are no moderated entities left, the case is considered reverted otherwise upheld.

@isoos isoos requested a review from jonasfj October 1, 2024 15:04
@isoos
Copy link
Collaborator Author

isoos commented Oct 2, 2024

Closing in favor of #8095

@isoos isoos closed this Oct 2, 2024
@isoos isoos deleted the fix-appeal-status branch October 2, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfj jonasfj Awaiting requested review from jonasfj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@isoos