-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronization logic for exported API #8203
Merged
jonasfj
merged 8 commits into
dart-lang:master
from
jonasfj:exported-api-draft-full-sync
Nov 7, 2024
Merged
Synchronization logic for exported API #8203
jonasfj
merged 8 commits into
dart-lang:master
from
jonasfj:exported-api-draft-full-sync
Nov 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
commented
Oct 29, 2024
isoos
reviewed
Oct 30, 2024
jonasfj
force-pushed
the
exported-api-draft-full-sync
branch
from
October 31, 2024 11:54
96be3e8
to
e069030
Compare
jonasfj
force-pushed
the
exported-api-draft-full-sync
branch
3 times, most recently
from
November 6, 2024 14:18
fb3a1f7
to
b7f7a99
Compare
isoos
reviewed
Nov 6, 2024
// Only delete the item if it's older than _minGarbageAge | ||
// This avoids any races where we delete files we've just created | ||
// TODO: Conditionally deletion API from package:gcloud would be better! | ||
await _bucket.tryDelete(item.name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: should we log the fact of deletion (here and elsewhere)? Maybe for a cursory later verification that we are not doing something stupid...
jonasfj
force-pushed
the
exported-api-draft-full-sync
branch
from
November 7, 2024 11:31
b7f7a99
to
55e624a
Compare
jonasfj
force-pushed
the
exported-api-draft-full-sync
branch
from
November 7, 2024 13:45
55e624a
to
e722e19
Compare
jonasfj
changed the title
Draft of what a full sync could look like
Synchronization logic for exported API
Nov 7, 2024
isoos
approved these changes
Nov 7, 2024
jonasfj
force-pushed
the
exported-api-draft-full-sync
branch
from
November 7, 2024 15:28
44a6479
to
51bb50d
Compare
isoos
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We identified 3 cases where we want to sync:
Package.updated
is changed.Leveraging the fact that
Bucket.list
frompackage:gcloud
now returnsObjectInfo
, we can dosynchronizePackage
such that it:TarballStorage
and takes the versions visible in version listing and usessynchronizeTarballs
.In the case where there is nothing to update, this should do:
Package
,PackageVersion
entities,md5Hash
).bucket.list
request to canonical bucket usingTarballStorage
.bucket.list
requests to exported API bucket to confirm that archives exported match those fromTarballStorage
.All in all, I think that's actually fairly efficient.