Add metadata to fake_gcloud #8243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
commented
Nov 7, 2024
| @@ -93,7 +93,6 @@ void main() { | |||
|
|
|||
| final sb = StringBuffer(); | |||
| storage.writeTo(sb); | |||
| expect(sb.length, 118); | |||
There was a problem hiding this comment.
I think this test is dumb, we're checking that MemStorage can be serialized, we should assert what size it has.
Just that we get the same data out when we're deserialize it, which is tested further down.
There was a problem hiding this comment.
Exact length check may be important if we are checking for a specific serialization format or making sure we are not doing excess or stupid things here. However, I do agree that this is not that important here.
szakarias
approved these changes
Nov 7, 2024
isoos
approved these changes
Nov 7, 2024
| @@ -93,7 +93,6 @@ void main() { | |||
|
|
|||
| final sb = StringBuffer(); | |||
| storage.writeTo(sb); | |||
| expect(sb.length, 118); | |||
There was a problem hiding this comment.
Exact length check may be important if we are checking for a specific serialization format or making sure we are not doing excess or stupid things here. However, I do agree that this is not that important here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.