Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found 9 files excluded from sound null safety in pkg/analyzer/ #49176

Closed
Tracked by #49169
devoncarew opened this issue Jun 3, 2022 · 2 comments
Closed
Tracked by #49169

Found 9 files excluded from sound null safety in pkg/analyzer/ #49176

devoncarew opened this issue Jun 3, 2022 · 2 comments
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.

Comments

@devoncarew
Copy link
Member

Found 9 files excluded from sound null safety in pkg/analyzer/:

pkg/analyzer/test/src/dart/ast/ast_test.dart:35:// @dart=2.9
pkg/analyzer/test/src/dart/ast/ast_test.dart:48:// @dart=2.9
pkg/analyzer/test/src/diagnostics/experiment_not_enabled_test.dart:37:// @dart=2.9
pkg/analyzer/test/src/diagnostics/mixin_inference_no_possible_substitution_test.dart:33:// @dart=2.8
pkg/analyzer/test/src/diagnostics/no_default_super_constructor_test.dart:89:// @dart=2.8
pkg/analyzer/test/src/diagnostics/no_default_super_constructor_test.dart:105:// @dart=2.8
pkg/analyzer/test/src/diagnostics/null_argument_to_non_null_type_test.dart:40:// @dart=2.9
pkg/analyzer/test/src/diagnostics/null_argument_to_non_null_type_test.dart:102:// @dart=2.9
pkg/analyzer/test/src/summary/elements_test.dart:30653:// @dart=2.8

See #49169 for more context.

@lrhn lrhn added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Jun 3, 2022
@bwilkerson
Copy link
Member

Every one of those is a comment embedded in a literal string, not a comment at the top of the file, and hence doesn't exclude the file from null safety.

@devoncarew
Copy link
Member Author

Ah, great, thanks for investigating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Projects
None yet
Development

No branches or pull requests

3 participants