Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Found 3 files excluded from sound null safety in frontend_server_client/ #1637

Closed
Tracked by #49169
devoncarew opened this issue Jun 3, 2022 · 0 comments · Fixed by #1641
Closed
Tracked by #49169

Found 3 files excluded from sound null safety in frontend_server_client/ #1637

devoncarew opened this issue Jun 3, 2022 · 0 comments · Fixed by #1641
Assignees
@jakemac53

Comments

@devoncarew
Copy link
Member

devoncarew commented Jun 3, 2022 •
edited
Loading

Found 3 files excluded from sound null safety in frontend_server_client/:

frontend_server_client/example/web_client.dart:5:// @dart = 2.8
frontend_server_client/test/frontend_sever_client_test.dart:35:// @dart = 2.8
frontend_server_client/test/frontend_sever_client_test.dart:244:// @dart=2.10

See dart-lang/sdk#49169 for more context.
This was referenced Jun 3, 2022
Closed
Closed
@devoncarew devoncarew changed the title Found 1 file excluded from sound null safety in frontend_server_client/ Found 3 files excluded from sound null safety in frontend_server_client/ Jun 6, 2022
@jakemac53 jakemac53 self-assigned this Jun 8, 2022
@jakemac53 jakemac53 mentioned this issue Jun 8, 2022
Merged
jakemac53 added a commit that referenced this issue Jun 9, 2022
@jakemac53
update frontend server compile api to always return a result, but hav…
ab82887 
…e a nullable dill (#1641)

Also fixes #1637.

This is a breaking API change, which I could revert if desired, but this allows us to get compiler output even if there is no output dill file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakemac53 jakemac53

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jakemac53 @devoncarew