Migrate dwds/web directory to null safety #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
reviewed
Jun 13, 2022
elliette
reviewed
Jun 13, 2022
elliette
reviewed
Jun 13, 2022
| } | ||
| }); | ||
| return reloadCompleter.future; | ||
| return reloadCompleter.future.then((value) { | ||
| sub.cancel(); |
There was a problem hiding this comment.
Why was this moved into the then?
There was a problem hiding this comment.
the sub is not defined inside the callback to window.onMessage.listen yet (at least analyzer does not think so:) - so i moved it to where it logically behaves the same but cancels the sub as before.
There was a problem hiding this comment.
Oh I see. Hmm, could the subscription be late (so we would follow the pattern as before)?
There was a problem hiding this comment.
No, it does not help unfortunately. I know this pattern is given as an example in many places but the analyzer is rejecting it currently (and I tend to agree with it, even just for safety, don't want the wrong pointer to be pinned here:)
elliette
reviewed
Jun 13, 2022
elliette
reviewed
Jun 13, 2022
added 2 commits
June 13, 2022 14:36
elliette
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate dwds/web directory to null safety
Towards: #1327