Migrate most of debugging/metadata and loaders directories to null safety #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 13, 2022 16:38
…ll-safety-dwds-3
…ll-safety-dwds-4
annagrin
commented
Jun 17, 2022
grouma
approved these changes
Jun 20, 2022
| return e.value; | ||
| } | ||
| } | ||
| _logger.warning('No module for server path $serverPath'); |
There was a problem hiding this comment.
Should we be throwing or returning a null value here instead?
There was a problem hiding this comment.
Added throwing instead, thanks!
There was a problem hiding this comment.
Oops, throwing breaks our flow (some non-module paths are passed to those API), changed to allowing null instead.
grouma
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate most of
debugging/metadataandloadersdirectories to null safety.Towards: #1327