Remove circular dependencies and unused code in preparation for further null safety migration #1664
Conversation
…ll-safety-dwds-domain
annagrin
changed the title
| @@ -671,21 +661,6 @@ class Debugger extends Domain { | |||
| logger.severe('Target crashed!'); | |||
| } | |||
|
|
|||
| /// Evaluate [expression] by calling Chrome's Runtime.evaluate | |||
There was a problem hiding this comment.
Duplicate - we already have this functionality in inspector.dart
dwds/lib/src/debugging/location.dart
Outdated
| final cache = _moduleToLocations[module]; | ||
| if (cache != null) return cache; | ||
| if (module == null) { | ||
| _logger.warning('No module for $url'); |
There was a problem hiding this comment.
We allow some urls here that have no modules, remove the warning as it generates a lot of spam
|
Very high level comment - this is a large PR and from the description it sounds like there are 3 separate issues being tackled here:
Are the code changes for these 3 interdependent or would it be possible to break this into 3 separate PRs to make it easier to review? |
I can try - will do the tests first, unused code next, break dependencies last |
|
I've created a few PRs to be checked in before the current change. After they are all in, the current change then will just cover refactoring to break circular dependencies:
|
Break circular dependencies:
AppInspectornot inherit fromDomainAppInspectortoChromeProxyServiceand removed it from theAppInspectorto make the API consistentvm_serviceAPI were not throwingSentinelExceptionwhen required, corrected nowAppInspectorInterfaceto break circular dependencies between files in debugging and utilities directoriesTowards: #1327