Migrate debugging/inspector.dart to null safety #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 13, 2022 11:38
elliette
reviewed
Jul 13, 2022
elliette
reviewed
Jul 14, 2022
| @@ -108,6 +108,6 @@ abstract class Domain { | |||
| late AppInspectorInterface inspector; | |||
| } | |||
|
|
|||
| void throwInvalidParam(String method, String message) { | |||
| Never throwInvalidParam(String method, String message) { | |||
There was a problem hiding this comment.
Never is a "bottom" type, it tells the compiler that this function never returns, so it can do null inference after it used, for example:
if (x ==null) {
throwInvalidParam();
}
// x is not null here
here are more details: https://dart.dev/null-safety/understanding-null-safety (top and bottom, unreachable code sections)
elliette
reviewed
Jul 14, 2022
elliette
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate debugging/inspector.dart to null safety. Add tests for inspector throwing ChromeDebugException on evaluation errors.
Towards: #1327