Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate rest of the services and dwds_vm_client.dart to null safety #1688

Merged
merged 13 commits into from
Jul 19, 2022
Merged

Migrate rest of the services and dwds_vm_client.dart to null safety #1688

merged 13 commits into from
Jul 19, 2022

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Jul 14, 2022 •
edited
Loading

Migrate rest of the services directory and dwds_vm_client.dart to null safety

  • connections
    • debug_connection.dart
  • services
    • app_debug_services.dart
    • debug_service.dart
  • lib
    • dwds_vm_client.dart

Towards: #1327

@annagrin annagrin marked this pull request as draft July 14, 2022 19:25
@annagrin annagrin marked this pull request as ready for review July 19, 2022 00:35
@annagrin annagrin requested review from elliette and grouma July 19, 2022 00:50
elliette
elliette approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion

@annagrin annagrin merged commit 8c8edc1 into dart-lang:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliette elliette elliette approved these changes

@grouma grouma Awaiting requested review from grouma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annagrin @elliette