removed build_daemon_ddc_and_canary_evaluate_test #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srujzs
approved these changes
Oct 31, 2024
|
We may want to add this back in the future if we want to support other formats, but right now we're always testing with DDC's AMD module format regardless of what we pass in: webdev/dwds/test/fixtures/context.dart Line 279 in 0e78eca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through investigation, we've determined that build_web_compilers exclusively supports the AMD format. As a result, build_daemon_ddc_and_canary_evaluate_test is not functioning as intended. It disregards the canaryFeatures flag and defaults to the AMD format regardless, making the test redundant. This issue proposes removing the test, as it does not accurately validate the intended functionality. #2512