Toggle Side menu with keyboard shortcuts #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: widgetHead fix overflow: removal of uncessary css
refractor: removal of uncessary css
New Feature: toggle side menu o control or cmd B
toogle on keyboard shortcut logic improvement
Adding a keyboard shortcut to toggle side menu
|
|
thrownullexception
requested changes
Jun 28, 2024
preventinf re attachment on every render
Ktbch
commented
Jun 29, 2024
| (event: KeyboardEvent) => { | ||
| if ((event.ctrlKey || event.metaKey) && event.keyCode === 66) { | ||
| setIsFullWidth(!isFullWidth); | ||
| console.log(isFullWidth); |
There was a problem hiding this comment.
Can we remove this log
removal of console.log from handleKeypess function
|
Removal of of console.log from handlekeypress function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new feature which allows user to toggle the side menu with a keyboard shortcut
Which is the combination of the following keys
Control/CMD + B
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information