Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix combine_similar for read_parquet if one branch does not project columns #254

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Fix combine_similar for read_parquet if one branch does not project columns #254

merged 1 commit into from
Aug 3, 2023

Conversation

phofl
Copy link
Collaborator

@phofl phofl commented Aug 2, 2023

…olumns

@phofl phofl changed the title Fix combine_similar for read_parquet if one branch does not project c… Fix combine_similar for read_parquet if one branch does not project columns Aug 2, 2023
@phofl
Copy link
Collaborator Author

phofl commented Aug 3, 2023

Merging this one, want to run the benchmarks again.

cc @rjzamora when you get back

@phofl phofl merged commit 6880388 into dask:main Aug 3, 2023
4 checks passed
@phofl phofl deleted the read_parquet branch August 3, 2023 08:17
rjzamora
rjzamora reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, makes sense. Thanks for fixing this @phofl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjzamora rjzamora rjzamora left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @rjzamora