Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out async taskgroup #8756

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Jul 10, 2024

This breaks out a change in #8468

separating this into its own submodule is a little cleaner and allows for an easier switch to an official task group once available

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ±0      29 suites  ±0   11h 16m 11s ⏱️ -56s
 4 083 tests ±0   3 963 ✅  - 1    112 💤 ±0   8 ❌ +1 
55 230 runs  ±0  52 788 ✅ +1  2 432 💤  - 1  10 ❌ ±0 

For more details on these failures, see this check.

Results for commit 4a6e62d. ± Comparison against base commit 8564dc7.

This pull request removes 8 and adds 8 tests. Note that renamed tests count towards both.
distributed.tests.test_core ‑ test_async_task_group_call_later_executes_delayed_task_in_background
distributed.tests.test_core ‑ test_async_task_group_call_soon_executes_task_in_background
distributed.tests.test_core ‑ test_async_task_group_close_closes
distributed.tests.test_core ‑ test_async_task_group_close_does_not_cancel_existing_tasks
distributed.tests.test_core ‑ test_async_task_group_close_prohibits_new_tasks
distributed.tests.test_core ‑ test_async_task_group_initialization
distributed.tests.test_core ‑ test_async_task_group_stop_cancels_long_running
distributed.tests.test_core ‑ test_async_task_group_stop_disallows_shutdown
distributed.tests.test_async_task_group ‑ test_async_task_group_call_later_executes_delayed_task_in_background
distributed.tests.test_async_task_group ‑ test_async_task_group_call_soon_executes_task_in_background
distributed.tests.test_async_task_group ‑ test_async_task_group_close_closes
distributed.tests.test_async_task_group ‑ test_async_task_group_close_does_not_cancel_existing_tasks
distributed.tests.test_async_task_group ‑ test_async_task_group_close_prohibits_new_tasks
distributed.tests.test_async_task_group ‑ test_async_task_group_initialization
distributed.tests.test_async_task_group ‑ test_async_task_group_stop_cancels_long_running
distributed.tests.test_async_task_group ‑ test_async_task_group_stop_disallows_shutdown

@fjetter fjetter merged commit eab58be into dask:main Jul 12, 2024
28 of 37 checks passed
@fjetter fjetter deleted the factor_out_async_tasgroup branch July 12, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant