Add support for configuring time units through ArrowReaderBuilder::with_schema #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progval
force-pushed
the
ts-precision
branch
2 times, most recently
from
29e3dcb
to
4212522
Compare
waynexia
pushed a commit
that referenced
this pull request
Oct 24, 2024
…th_schema (#93) * Add support for configuring time units through ArrowReaderBuilder::with_schema * Add tests for milliseconds and microseconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly resolves #75, though users may want to decode timestamps as two i64 columns in order to preserve both precision and range. (Or could Arrow be extended to support i128 timestamps?)