Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): use mainline sqlglot #11693

Merged
merged 8 commits into from
Oct 23, 2024
Merged

feat(ingest): use mainline sqlglot #11693

merged 8 commits into from
Oct 23, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 22, 2024

This moves us onto using sqlglot instead of our acryl-sqlglot fork.

Closes #10184.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 22, 2024
Copy link

Hello @hsheth2 😄

Thank you so much for opening a pull request!

Image
You can check out your contributor card and see all your past stats here!

@hsheth2 hsheth2 marked this pull request as ready for review October 22, 2024 19:56
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Oct 23, 2024
@hsheth2 hsheth2 merged commit 35f30b7 into master Oct 23, 2024
73 checks passed
@hsheth2 hsheth2 deleted the sqlglot-mainline branch October 23, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

acryl-sqlglot fork - plans to contribute/switch to upstream?
2 participants