Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(datahub-frontend): upgrade frontend pac4j #11709

Merged
merged 2 commits into from
Oct 28, 2024
Merged

refactor(datahub-frontend): upgrade frontend pac4j #11709

merged 2 commits into from
Oct 28, 2024

Conversation

david-leifker
Copy link
Collaborator

@david-leifker david-leifker commented Oct 24, 2024 •
edited
Loading

  • Upgrade play components
    • scala 2.13
    • pac4j 6.0.6
    • oauth2-oidc-sdk/jose-jwt
    • java 11 -> java 17
  • Fix logout url (should not default to /, should be /login)
  • Make SSO enable check consistent for both auth and logout controllers

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 24, 2024
@david-leifker
Copy link
Collaborator Author

Will have to debug the unit test. Passes locally consistently.

@david-leifker david-leifker force-pushed the play-oidc-nimbus-upgrade branch 3 times, most recently from 2f8ff30 to 5ab048b Compare October 25, 2024 20:47
@david-leifker
refactor(datahub-frontend): upgrade frontend pac4j
cb330c6 
* Upgrade play components
   * scala 2.13
   * pac4j 6.0.6
   * oauth2-oidc-sdk/jose-jwt
   * java 11 -> java 17
@david-leifker david-leifker merged commit 0e4b3c1 into datahub-project:master Oct 28, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

@noggi noggi Awaiting requested review from noggi

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-leifker @RyanHolstien