Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a scheduled GitHub Action to check upstream version #275

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Add a scheduled GitHub Action to check upstream version #275

merged 1 commit into from
Jul 24, 2023

Conversation

jlaine
Copy link
Contributor

@jlaine jlaine commented Jul 24, 2023

Twice a day, a scheduled action checks the latest upstream release and compares it to the current phonenumbers version. The check succeeds if and only if the two versions match.

See #273

@jlaine
Copy link
Contributor Author

jlaine commented Jul 24, 2023

Notes:

  • I don't know what your "home" timezone is, so feel free to suggest a more convenient time
  • I have included the "workflow_dispatch" trigger so the action can be run manually
  • So far I've only witness manually triggered runs, I'm not sure if this is because I'm operating on a fork

Here is a scheduled run of the action:

https://github.com/jlaine/python-phonenumbers/actions/runs/5642100157

Copy link
Owner

@daviddrysdale daviddrysdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you – just a couple of minor nits.

tools/python/checkupstreamversion.py Outdated Show resolved Hide resolved
.github/workflows/upstream.yml Outdated Show resolved Hide resolved
tools/python/checkupstreamversion.py Outdated Show resolved Hide resolved
.github/workflows/upstream.yml Outdated Show resolved Hide resolved
.github/workflows/upstream.yml Outdated Show resolved Hide resolved
.github/workflows/upstream.yml Outdated Show resolved Hide resolved
tools/python/checkupstreamversion.py Outdated Show resolved Hide resolved
tools/python/checkupstreamversion.py Outdated Show resolved Hide resolved
tools/python/checkupstreamversion.py Outdated Show resolved Hide resolved
tools/python/checkupstreamversion.py Outdated Show resolved Hide resolved
tools/python/checkupstreamversion.py Outdated Show resolved Hide resolved
Twice a day, a scheduled action checks the latest upstream release and
compares it to the current `phonenumbers` version. The check succeeds if
and only if the two versions match.

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@jlaine
Copy link
Contributor Author

jlaine commented Jul 24, 2023

Thanks to @AA-Turner for all the suggested changes!

I think I've addressed all the requested changes, I'd still value your input on whether you want to keep the workflow_dispatch.

@daviddrysdale daviddrysdale merged commit b41129d into daviddrysdale:dev Jul 24, 2023
@daviddrysdale
Copy link
Owner

Thanks @jlaine and @AA-Turner !

@jlaine
Copy link
Contributor Author

jlaine commented Jul 24, 2023

Oh crud. The if github.repository_owner == "daviddrysdale" broke the build:

https://github.com/daviddrysdale/python-phonenumbers/actions/runs/5644422744

@daviddrysdale
Copy link
Owner

Yeah, it seems that an if: line uses GitHub expression syntax, not YAML syntax, and so strings need to be single quoted. No worries, easy to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants