Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of multiple column unique keys in snapshots #326

Merged
merged 17 commits into from
Oct 19, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Oct 1, 2024

resolves #181
related to dbt-labs/dbt-core#10795

Problem

Implement use of a list for a unique_key in snapshots

Solution

Check whether the unique_key is a list and modify the SQL.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@gshank gshank requested a review from a team as a code owner October 1, 2024 18:40
@cla-bot cla-bot bot added the cla:yes label Oct 1, 2024
Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few suggestions focusing on minimizing the amount of jinja that we have and making that jinja more readable. Let me know what you think.

@gshank gshank requested a review from mikealfare October 18, 2024 15:20
Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every time we remove jinja, an angel gets its wings.

@mikealfare mikealfare merged commit 5fd5467 into main Oct 19, 2024
10 checks passed
@mikealfare mikealfare deleted the multiple-snapshot-unique-keys branch October 19, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Allow unique_key for snapshots to take a list
4 participants