Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update expected values #916

Merged
merged 1 commit into from
Sep 11, 2023
Merged

update expected values #916

merged 1 commit into from
Sep 11, 2023

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Sep 7, 2023 •
edited
Loading

resolves #915
docs dbt-labs/docs.getdbt.com/#

Problem

change to agate_helper in core requires update to data type expected value in test.

This pr may seem familiar is a new version of one we recently reverted in order to make release see #890 and #894

Solution

merge into main and backport to 1.6.latest when core does

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 requested a review from a team as a code owner September 7, 2023 21:16
@McKnight-42 McKnight-42 self-assigned this Sep 7, 2023
@cla-bot cla-bot bot added the cla:yes label Sep 7, 2023
@colin-rogers-dbt colin-rogers-dbt merged commit 0a9ab72 into main Sep 11, 2023
30 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the McKnight-42/ADAP-877 branch September 11, 2023 16:41
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Sep 11, 2023
@McKnight-42 @github-actions
push up fix to core change in agate_helper (#916)
b72ab29 
(cherry picked from commit 0a9ab72)
colin-rogers-dbt pushed a commit that referenced this pull request Sep 11, 2023
@github-actions @McKnight-42
push up fix to core change in agate_helper (#916) (#922)
dfe65eb 
(cherry picked from commit 0a9ab72)

Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Apr 24, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@mikealfare mikealfare Awaiting requested review from mikealfare mikealfare is a code owner automatically assigned from dbt-labs/adapters

@nathaniel-may nathaniel-may Awaiting requested review from nathaniel-may

Assignees

@McKnight-42 McKnight-42

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADAP-877] [Bug] Updating agate_helper in core requires update in of data type in some tests
2 participants
@McKnight-42 @colin-rogers-dbt