Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2776] [Feature] Enable-post-parse-population-of-dbt-custom-env #7998

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

gem7318
Copy link
Contributor

@gem7318 gem7318 commented Jun 29, 2023

Description

See details in the issue: #8010.

Checklist

@gem7318 gem7318 requested a review from a team as a code owner June 29, 2023 23:01
@gem7318 gem7318 requested a review from QMalcolm June 29, 2023 23:01
@cla-bot
Copy link

cla-bot bot commented Jun 29, 2023

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @gem7318

@cla-bot cla-bot bot added the cla:yes label Jun 29, 2023
@jtcohen6
Copy link
Contributor

jtcohen6 commented Jun 30, 2023

@gem7318 Cool to see the PR! I'm not strictly opposed to this from a product/UX perspective. Do you mind opening a quick issue to outline the use case? (You've written some of it above, and a bit more in our shared slack thread)

Update:

Happy to have you contributing :)

@gem7318 gem7318 changed the title patch(events/functions): enable-repopulation-of-metadata-vars patch(events): enable-repopulation-of-metadata-vars Jul 2, 2023
@gem7318 gem7318 changed the title patch(events): enable-repopulation-of-metadata-vars feature(events): enable-repopulation-of-metadata-vars Jul 2, 2023
@gem7318 gem7318 changed the title feature(events): enable-repopulation-of-metadata-vars feature(events): enable-post-parse-population-of-metadata-vars Jul 2, 2023
@gem7318 gem7318 changed the title feature(events): enable-post-parse-population-of-metadata-vars feature(events): enable-post-parse-population-of-dbt-custom-env Jul 2, 2023
@gem7318 gem7318 changed the title feature(events): enable-post-parse-population-of-dbt-custom-env [CT-2776] Enable-post-parse-population-of-dbt-custom-env Jul 2, 2023
@gem7318 gem7318 changed the title [CT-2776] Enable-post-parse-population-of-dbt-custom-env [CT-2776] [Feature] Enable-post-parse-population-of-dbt-custom-env Jul 2, 2023
@jtcohen6 jtcohen6 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Jul 4, 2023
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First off, thank you for doing this work @gem7318! This looks great, and we should get this in 🙂

The second thing is, in a perfect world this should go away some time in the future. Basically, one shouldn't have to alter the environment variables mid run to get the desired results. This seems indicative of larger structural issues we need to address. However, I can make no guarantees of when we'll address the structural changes necessary to support the desired functionality without altering the environment variables mid run. Thus we should absolutely move forward with allowing this.

@QMalcolm
Copy link
Contributor

QMalcolm commented Aug 2, 2023

@gem7318 It looks like there are two remaining github actions that are required to be run before we can merge this. I believe main needs to be merged into this branch so that this branch has the required github actions (they were recent additions to our github workflow, and are now required).

@gem7318
Copy link
Contributor Author

gem7318 commented Aug 4, 2023

@gem7318 It looks like there are two remaining github actions that are required to be run before we can merge this. I believe main needs to be merged into this branch so that this branch has the required github actions (they were recent additions to our github workflow, and are now required).

@QMalcolm I just synced my fork + pulled main + rebased out of habit - let me know if this isn't what we were looking (looks good to me though).

image

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #7998 (b2dea01) into main (f637092) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #7998      +/-   ##
==========================================
- Coverage   86.28%   86.23%   -0.05%     
==========================================
  Files         174      174              
  Lines       25518    25518              
==========================================
- Hits        22017    22005      -12     
- Misses       3501     3513      +12     
Files Changed Coverage Δ
core/dbt/events/functions.py 92.79% <100.00%> (ø)

... and 2 files with indirect coverage changes

@QMalcolm
Copy link
Contributor

QMalcolm commented Aug 4, 2023

A -0.05% in test coverage feels acceptable. Gonna use my judgement and move forward, merging 🙂

@QMalcolm QMalcolm merged commit 424c636 into dbt-labs:main Aug 4, 2023
47 of 48 checks passed
@gem7318
Copy link
Contributor Author

gem7318 commented Aug 4, 2023

A -0.05% in test coverage feels acceptable. Gonna use my judgement and move forward, merging 🙂

LGTM and thank you both🙏🏻 CC @jtcohen6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants