-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-2776] [Feature] Enable-post-parse-population-of-dbt-custom-env #7998
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @gem7318 |
@gem7318 Cool to see the PR! I'm not strictly opposed to this from a product/UX perspective. Do you mind opening a quick issue to outline the use case? (You've written some of it above, and a bit more in our shared slack thread) Update: Happy to have you contributing :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First off, thank you for doing this work @gem7318! This looks great, and we should get this in 🙂
The second thing is, in a perfect world this should go away some time in the future. Basically, one shouldn't have to alter the environment variables mid run to get the desired results. This seems indicative of larger structural issues we need to address. However, I can make no guarantees of when we'll address the structural changes necessary to support the desired functionality without altering the environment variables mid run. Thus we should absolutely move forward with allowing this.
@gem7318 It looks like there are two remaining github actions that are required to be run before we can merge this. I believe main needs to be merged into this branch so that this branch has the required github actions (they were recent additions to our github workflow, and are now required). |
@QMalcolm I just synced my fork + pulled |
Codecov Report
@@ Coverage Diff @@
## main #7998 +/- ##
==========================================
- Coverage 86.28% 86.23% -0.05%
==========================================
Files 174 174
Lines 25518 25518
==========================================
- Hits 22017 22005 -12
- Misses 3501 3513 +12
|
A -0.05% in test coverage feels acceptable. Gonna use my judgement and move forward, merging 🙂 |
LGTM and thank you both🙏🏻 CC @jtcohen6 |
Description
See details in the issue: #8010.
Checklist
changie new
to create a changelog entry