Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple unique keys in snapshots #10795

Merged
merged 12 commits into from
Oct 22, 2024
Merged

Support multiple unique keys in snapshots #10795

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
67eae27
Make SnapshotConfig.unique_key an Optional[Union[str, List[str]]]
gshank Sep 30, 2024
9d0cc3c
Update dev-requirements.txt
gshank Sep 30, 2024
8ee3f63
Changie, update test
gshank Oct 1, 2024
8cf1719
Remove instrumentation from test
gshank Oct 1, 2024
2fd03f0
Use dbt-common branch with is_list filter
gshank Oct 1, 2024
bef8ea2
Remove unneeded import
gshank Oct 1, 2024
479f5c7
Merge branch 'main' into multiple-snapshot-unique-keys
gshank Oct 17, 2024
d6ef4ba
Merge branch 'main' into multiple-snapshot-unique-keys
gshank Oct 22, 2024
46f2e6a
Remove branches from dev-requirements.txt
gshank Oct 22, 2024
6e30d29
Add test case
gshank Oct 22, 2024
f421107
Bump dbt-common and dbt-adapters versions
gshank Oct 22, 2024
885d9b4
Make it work
gshank Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/dbt/artifacts/resources/v1/snapshot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class SnapshotMetaColumnNames(dbtClassMixin):
class SnapshotConfig(NodeConfig):
materialized: str = "snapshot"
strategy: Optional[str] = None
unique_key: Optional[str] = None
unique_key: Optional[Union[str, List[str]]] = None
target_schema: Optional[str] = None
target_database: Optional[str] = None
updated_at: Optional[str] = None
Expand Down
2 changes: 1 addition & 1 deletion dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
git+https://github.com/dbt-labs/dbt-adapters.git@main
git+https://github.com/dbt-labs/dbt-adapters.git@multiple-snapshot-unique-keys
git+https://github.com/dbt-labs/dbt-adapters.git@main#subdirectory=dbt-tests-adapter
git+https://github.com/dbt-labs/dbt-common.git@main
git+https://github.com/dbt-labs/dbt-postgres.git@main
Expand Down
Loading