Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: in profiles.yml -> flags: in dbt_project.yml #4709

Closed
FishtownBuildBot opened this issue Jan 4, 2024 · 5 comments · Fixed by #4814
Closed

config: in profiles.yml -> flags: in dbt_project.yml #4709

FishtownBuildBot opened this issue Jan 4, 2024 · 5 comments · Fixed by #4814
Assignees
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.8 improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@FishtownBuildBot
Copy link

FishtownBuildBot commented Jan 4, 2024

At a minimum, update body to include a link to the page on docs.getdbt.com requiring updates and what part(s) of the page you would like to see updated.

Issue: dbt-labs/dbt-core#9183
PR: dbt-labs/dbt-core#9289

Pages to update:

Starting in v1.8:

In dbt_project.yml, user config will look like:

# dbt_project.yml
flags:
  send_anonymous_usage_stats: True
  ...
@runleonarun runleonarun added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear dbt Core The changes proposed in this issue relate to dbt Core labels Jan 4, 2024
@dbeatty10 dbeatty10 changed the title Docs Changes Needed from dbt-core PR #9289 config: in profiles.yml -> flags: in dbt_project.yml Jan 13, 2024
@matthewshaver matthewshaver self-assigned this Jan 17, 2024
@jtcohen6
Copy link
Collaborator

@matthewshaver Mind if I take this one from you? I'd like to use this docs-writing as an opportunity to formalize my own sense of what migrations will look like going forward

@jtcohen6 jtcohen6 assigned jtcohen6 and unassigned matthewshaver Jan 22, 2024
@MichelleArk
Copy link
Contributor

Related issue of project flag usage: #4787

@runleonarun
Copy link
Collaborator

@jtcohen6 (just to overly communicate in both your issues 😆 ) I think we should aim to have all issues addressed by Friday 2/23 to give reviewers and authors enough time. Let me know if you need support!

@jtcohen6
Copy link
Collaborator

@runleonarun I've marked #4814 ready for review! (After working through @dbeatty10's excellent first round of feedback)

@runleonarun
Copy link
Collaborator

Thanks @jtcohen6! @matthewshaver will review it today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.8 improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants