Project flags, for global config defaults + behavior change migrations #4814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
3 tasks
dbeatty10
reviewed
Jan 29, 2024
There was a problem hiding this comment.
You are a tour de force 🤩
Didn't look at any previews yet, but read through the code and left some comments below.
Something we should consider handling either within this PR or a separate one: #4366
See #4366 (comment) for one idea to tie together CLI flags and environment variable names. Unfortunately, it wouldn't also tie together flag settings within dbt_project.yml too.
jtcohen6
force-pushed
the
jerco/flags-behavior-changes
branch
from
b249e9c
to
5a66d8c
Compare
jtcohen6
commented
Feb 21, 2024
There was a problem hiding this comment.
Something we should consider handling either within this PR or a separate one: #4366
I gave it a go! It's not the prettiest, but I stand by the information in there. Let me know what you think.
|
@matthewshaver will review this on Thursday. Thanks for all the work Doug and Jerco! |
…dbt.com into indirect-selection4773
1 task
runleonarun
reviewed
Feb 23, 2024
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
## What are you changing in this pull request and why? Updates the profiles.yml page to reflect the changes to global configs ## Checklist <!-- Uncomment when publishing docs for a prerelease version of dbt: - [ ] Add versioning components, as described in [Versioning Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages) - [ ] Add a note to the prerelease version [Migration Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/docs/dbt-versions/core-upgrade) --> - [ ] Review the [Content style guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md) so my content adheres to these guidelines. - [ ] For [docs versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning), review how to [version a whole page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version) and [version a block of content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content). - [ ] Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch." Adding or removing pages (delete if not applicable): - [ ] Add/remove page in `website/sidebars.js` - [ ] Provide a unique filename for new pages - [ ] Add an entry for deleted pages in `website/static/_redirects` - [ ] Run link testing locally with `npm run build` to update the links that point to deleted pages
resolves #4773 ## What are you changing in this pull request and why? <!--- Describe your changes and why you're making them. If related to an open issue or a pull request on dbt Core, then link to them here! To learn more about the writing conventions used in the dbt Labs docs, see the [Content style guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md). --> ## Checklist <!-- Uncomment when publishing docs for a prerelease version of dbt: - [ ] Add versioning components, as described in [Versioning Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages) - [ ] Add a note to the prerelease version [Migration Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/docs/dbt-versions/core-upgrade) --> - [ ] Review the [Content style guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md) so my content adheres to these guidelines. - [ ] For [docs versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning), review how to [version a whole page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version) and [version a block of content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content). - [ ] Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch." Adding or removing pages (delete if not applicable): - [ ] Add/remove page in `website/sidebars.js` - [ ] Provide a unique filename for new pages - [ ] Add an entry for deleted pages in `website/static/_redirects` - [ ] Run link testing locally with `npm run build` to update the links that point to deleted pages
Adding page to sidebar
Preventing page loop
Fixing spacing
dbeatty10
approved these changes
Feb 27, 2024
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
matthewshaver
approved these changes
Feb 27, 2024
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4366
resolves #4709
resolves #4787
resolves #2894
What are you changing in this pull request and why?
dbt_project.ymlinstead ofprofiles.ymlPreviews
Most important changes:
Other new pages:
Other significant edits:
Edited links:
Deleted:
Minor edits (moved and re-titled):
Other:
Checklist
Adding or removing pages (delete if not applicable):
website/sidebars.jswebsite/vercel.jsonnpm run buildto update the links that point to deleted pages