Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5 Feature deprecations for target and logs #3129

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Apr 3, 2023

What are you changing in this pull request and why?

We are deprecating two flags that can be set in the dbt project yml file. They will still have two other options to implement, and 1.5 supports backward compatibility, but users will need to migrate off the feature before a future version disables it entirely.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry _redirects
  • Ran link testing to update the links that point to the deleted page

@matthewshaver matthewshaver requested a review from a team as a code owner April 3, 2023 18:32
@netlify
Copy link

netlify bot commented Apr 3, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 050164e
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/642b4af2622ead0009deb6ed
😎 Deploy Preview https://deploy-preview-3129--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs labels Apr 3, 2023
@matthewshaver matthewshaver linked an issue Apr 3, 2023 that may be closed by this pull request
1 task
@github-actions github-actions bot added the size: small This change will take 1 to 2 days to address label Apr 3, 2023
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good in the output!

</VersionBlock>

<VersionBlock lastVersion="1.4">

The precedence order is: CLI flag > env var > `dbt_project.yml`

</VersionBlock>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize we could nest these version blocks!

@matthewshaver matthewshaver merged commit 7f76e78 into current Apr 3, 2023
@matthewshaver matthewshaver deleted the deprecated-features branch April 3, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated: setting log-path + target-path in dbt_project.yml
2 participants