-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AdapterVersion log message #3734
Conversation
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@dbeatty10 : folded in your review comment. can i get a re-review? tysm! |
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jerco was hoping for these updates to include an example of what the "registered adapter" version introduced in dbt-labs/dbt-core#7862 looks like too.
Here's an example of how the registered adapter version displays within logs/dbt.log
:
[0m13:13:48.572182 [info ] [MainThread]: Registered adapter: snowflake=1.6.0
thanks for flagging, @dbeatty10 ! added content for the "registered adapter version". not sure if i did it right tho. can you take a look? tysm! |
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are you changing in this pull request and why?
Updating the AdapterVersion log message in this section:
https://docs.getdbt.com/docs/dbt-versions/core#how-we-version-adapter-plugins
Resolves #3726
Checklist