Update AdapterVersion log message #3734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
content
dbeatty10
reviewed
Jul 13, 2023
nghi-ly
commented
Jul 13, 2023
nghi-ly
commented
Jul 13, 2023
dbeatty10
reviewed
Jul 13, 2023
|
@dbeatty10 : folded in your review comment. can i get a re-review? tysm! |
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
dbeatty10
reviewed
Jul 13, 2023
There was a problem hiding this comment.
Jerco was hoping for these updates to include an example of what the "registered adapter" version introduced in dbt-labs/dbt-core#7862 looks like too.
Here's an example of how the registered adapter version displays within logs/dbt.log:
[0m13:13:48.572182 [info ] [MainThread]: Registered adapter: snowflake=1.6.0
nghi-ly
commented
Jul 13, 2023
|
thanks for flagging, @dbeatty10 ! added content for the "registered adapter version". not sure if i did it right tho. can you take a look? tysm! |
dbeatty10
reviewed
Jul 13, 2023
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
Updating the AdapterVersion log message in this section:
https://docs.getdbt.com/docs/dbt-versions/core#how-we-version-adapter-plugins
Resolves #3726
Checklist