Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dbt-athena-community to trusted adapters list #4028

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Add dbt-athena-community to trusted adapters list #4028

merged 3 commits into from
Sep 6, 2023

Conversation

dataders
Copy link
Contributor

@dataders dataders commented Sep 6, 2023

What are you changing in this pull request and why?

resolves: #4022

@dataders dataders requested a review from a team as a code owner September 6, 2023 15:46
@netlify
Copy link

netlify bot commented Sep 6, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com canceled.

Name Link
🔨 Latest commit dbaf49e
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64f8e657bb4f8a0008448d55

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Sep 6, 2023
@mirnawong1
Copy link
Contributor

mirnawong1 commented Sep 6, 2023 •
edited
Loading

this looks awesome @dataders 🙏 ! i would recommend adding hide_table_of_contents: true to the frontmatter in the trusted-adapters.md file to hide the right table of contents. this will also make the trusted adapter cards not look too squished and affect the ux (esp once more adapters are added)

Screenshot 2023-09-06 at 18 35 58

runleonarun
runleonarun approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now! :shipit:

@dataders dataders merged commit 9b292b9 into current Sep 6, 2023
10 checks passed
@dataders dataders deleted the trust_dbt-athena-community branch September 6, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runleonarun runleonarun runleonarun approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dbt-athena-community to trusted adapter list
3 participants
@dataders @mirnawong1 @runleonarun