-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update reference-models-in-another-project.md #4209
Conversation
add info on project dependencies. Closes #4026
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
website/docs/faqs/Models/reference-models-in-another-project.md
Outdated
Show resolved
Hide resolved
website/docs/faqs/Models/reference-models-in-another-project.md
Outdated
Show resolved
Hide resolved
website/docs/faqs/Models/reference-models-in-another-project.md
Outdated
Show resolved
Hide resolved
website/docs/faqs/Models/reference-models-in-another-project.md
Outdated
Show resolved
Hide resolved
website/docs/faqs/Models/reference-models-in-another-project.md
Outdated
Show resolved
Hide resolved
website/docs/faqs/Models/reference-models-in-another-project.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs-getdbt-com-git-mirnawong1-patch-12-dbt-labs.vercel.app/faqs/models/reference-models-in-another-project isn't redirecting (when Models is lowercase). I guess this is another instance of vercel being case sensitive - is there a way to work around that? at minimum I think we'll need to just add a redirect for the lowercase version too.
website/docs/faqs/Models/reference-models-in-another-project.md
Outdated
Show resolved
Hide resolved
|
||
1. **Packages**: You can install [packages](/docs/build/packages) as a way to add another project to your dbt project, including other projects you've created. When you install a project as a package, you bring in its entire source code, making its macros and models available in your own project. | ||
|
||
While this is useful for reusing code and sharing macros, it may not be the best approach for large-scale collaboration, especially in larger organizations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is useful for reusing code and sharing macros, it may not be the best approach for large-scale collaboration, especially in larger organizations. | |
This is a useful way to share macros between projects, but is impractical for sharing models at scale because the importing project has to process the full source code of the upstream project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha, thanks for testing that @joellabes ! I've added the lowercase redirect but i don't think there's any other way around it. I'm going to cc @john-rock @JKarlavige or @breezyfasano in case they have more insight?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok tested it and it worked! thanks @joellabes !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a redirect is definitely the quickest fix. I have a task to look into the Vercel URLs to see how we can serve the same page both lower and capital case in URLs. Here's a link to the ticket https://app.asana.com/0/1200099998847559/1205508339405074/f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the meantime this lgtm!
remove faq page and direct users to source
Closes #4026