Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding databricks materialization #4211

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Adding link to Databricks materializations to migration guide

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@matthewshaver matthewshaver requested a review from a team as a code owner October 6, 2023 17:21
@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 5:22pm

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: x-small This change will take under 3 hours to fix. Docs team Authored by the Docs team @dbt Labs and removed content Improvements or additions to content guides Knowledge best suited for Guides labels Oct 6, 2023
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion but approving!

@@ -59,7 +59,7 @@ Supported on:
- [Postgres](/reference/resource-configs/postgres-configs#materialized-view)
- [Redshift](/reference/resource-configs/redshift-configs#materialized-view)
- [Snowflake](/reference/resource-configs/snowflake-configs#dynamic-tables)
- Databricks (docs forthcoming)
- [Databricks](/reference/resource-configs/databricks-configs#materialized-views-and-streaming-tables)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@@ -59,7 +59,7 @@ Supported on:
- [Postgres](/reference/resource-configs/postgres-configs#materialized-view)
- [Redshift](/reference/resource-configs/redshift-configs#materialized-view)
- [Snowflake](/reference/resource-configs/snowflake-configs#dynamic-tables)
- Databricks (docs forthcoming)
- [Databricks](/reference/resource-configs/databricks-configs#materialized-views-and-streaming-tables)

Support for BigQuery coming soon.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewshaver should this also be a bullet point?

Suggested change
Support for BigQuery coming soon.
* Support for BigQuery coming soon.

@matthewshaver matthewshaver merged commit 542fa07 into current Oct 6, 2023
10 checks passed
@matthewshaver matthewshaver deleted the databricks-materialized branch October 6, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants