Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sl-jdbc.md #4604

Merged
merged 33 commits into from
Jan 23, 2024
Merged

Update sl-jdbc.md #4604

merged 33 commits into from
Jan 23, 2024

Conversation

rpourzand
Copy link
Contributor

We're making some changes to our API (not released yet), so I'm preemptively adding info.

What are you changing in this pull request and why?

Checklist

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to the deleted page

We're making some changes to our API (not released yet), so I'm preemptively adding info.
@rpourzand rpourzand requested a review from a team as a code owner December 7, 2023 00:52
Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com 🛑 Canceled (Inspect) Jan 23, 2024 11:40am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Dec 7, 2023
Copy link
Contributor

@DevonFulcher DevonFulcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, based on Paul's demo. I'm not sure when these features go live though.

Adding an example from Paul
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: x-small This change will take under 3 hours to fix. labels Dec 8, 2023
copying the same over for jdbc -- maybe we can figure out a way to put this somewhere so we don't have to duplicate
timedimension is no longer optional
fixing some updates
Copy link

@plypaul plypaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside form comments

website/docs/docs/dbt-cloud-apis/sl-graphql.md Outdated Show resolved Hide resolved
website/docs/docs/dbt-cloud-apis/sl-jdbc.md Outdated Show resolved Hide resolved
@plypaul
Copy link

plypaul commented Dec 8, 2023

The ambiguous resolution stack has not been released yet, so do we need to wait for that to go out before merging this?

making paul's reco's
paul's recos
also adding a dimension only example to it
Copy link
Contributor

@Jstein77 Jstein77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me. I think we need to add some more examples of how to query multi-hop dimensions in the CLI - but I can add that in a different PR.

@rpourzand
Copy link
Contributor Author

@mirnawong1 this is ready to merge!

@mirnawong1
Copy link
Contributor

double checked and looking great! merging 🚢 - thank you so much @rpourzand !

@mirnawong1 mirnawong1 merged commit d5e43da into current Jan 23, 2024
7 checks passed
@mirnawong1 mirnawong1 deleted the rpourzand-patch-api-updates branch January 23, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content January-2024 size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants