Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy-jobs.md #4611

Merged
merged 9 commits into from
Dec 13, 2023
Merged

Update deploy-jobs.md #4611

merged 9 commits into from
Dec 13, 2023

Conversation

Tonayya
Copy link
Contributor

@Tonayya Tonayya commented Dec 8, 2023

What are you changing in this pull request and why?

Added some examples where we are using the L expression to specify the last day of the month. Relevant conversation can be found in Slack here.

Checklist

Added some examples where we are using the L expression to specify the last day of the month. Relevant conversation can be found in Slack [here](https://dbt-labs.slack.com/archives/C04KKUHLT32/p1702002328874979).
@Tonayya Tonayya requested a review from a team as a code owner December 8, 2023 03:00
Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 2:11pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Dec 8, 2023
@Tonayya
Copy link
Contributor Author

Tonayya commented Dec 8, 2023

Hallo @mirnawong1 please let me know if this all good and if I need to change anything. Thank you love your work <3

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Tonayya nice one and thank you for opening this pr up to clarify/add examples. super useful and thank you for contributing. going to merge this fo ryou!

@Tonayya
Copy link
Contributor Author

Tonayya commented Dec 10, 2023

Hi @mirnawong1 sorry I closed the PR because I thought changes were already deployed. But it doesn't look like it was in the docs. Did I do something wrong? :(

@mirnawong1 mirnawong1 reopened this Dec 11, 2023
@mirnawong1
Copy link
Contributor

hey @Tonayya all good! i think i was going to merge it after the slack approval/clarification wrt emea/au MT. i'll merge this for you and will save you that step 🙏

@mirnawong1 mirnawong1 merged commit dd0f216 into current Dec 13, 2023
7 checks passed
@mirnawong1 mirnawong1 deleted the Tonayya-patch-1 branch December 13, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants