Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sl deprecation #4620
Sl deprecation #4620
Changes from all commits
573b65e
8b00253
a280913
d569754
09407b6
8ee808d
9edcc6d
f9c7d9b
4113f88
e7edde9
36a30c0
3c5bb3f
c4cdcda
f236d2b
f0235af
cfde487
0408a62
66f2ce8
eda9ad9
a761276
16e9d20
7166bb7
c84a378
a0b2d9d
a4e83e4
735edf3
5a2b28e
a8a3e31
1d66dfd
8083366
fb52a37
ec3a6da
abcafe4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know exactly how this works, but wouldn't removing this make it so our available integrations to the new SL appear before version 1.6 of the docs? We still don't support version < 1.6 of dbt Core, so I think we still want to keep this absent when users are browsing the version of docs that are < 1.6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @DevonFulcher ! that's definitely a great point and i intentionally removed it because the prerequisites do let users know they should be on dbt v1.6 and higher to use the SL or metricflow. also, is it a bad thing to have the revamped SL presented to users who are not on dbt v1.6 or higher? it might be a helpful motivator to upgrade their version?
i do think the initial PR didn't include a callout letting ppl know about the deprecation but i just added it so that users know the legacy SL and dbt metrics was removed and if they'd like to use the SL or metricflow, they can upgrade if they choose -- what do you think about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya, that sounds great! Thank you!