Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exports content and rn #4689

Merged
merged 150 commits into from
Feb 7, 2024
Merged

add exports content and rn #4689

merged 150 commits into from
Feb 7, 2024

Conversation

mirnawong1
Copy link
Contributor

this pr is to prepare for the SL exports functionality that the team have communicated with users.

This is still a wip and needs more context.

Checklist:

  • Engineering review
  • SME review
  • Docs review

@mirnawong1 mirnawong1 requested a review from a team as a code owner December 21, 2023 20:31
Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com 🛑 Canceled (Inspect) Feb 7, 2024 5:14pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Dec 21, 2023
Copy link
Contributor Author

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving outstanding questions (sorry they're in caps)

Copy link
Contributor Author

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding comments


If exports aren't needed, you can set the value(s) to `FALSE` (`DBT_INCLUDE_SAVED_QUERY=FALSE`).

<Lightbox src="/img/docs/dbt-cloud/semantic-layer/deploy_exports.jpg" width="90%" title="Add an environment variable to run exports in your production run." />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jstein77 i updated teh screenshot so it's super clear that the key only contains DBT_INCLUDE_SAVED_QUERY and users don't make the same mistake i did

Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! non-blocking nits

website/docs/docs/use-dbt-semantic-layer/exports.md Outdated Show resolved Hide resolved
website/docs/docs/use-dbt-semantic-layer/exports.md Outdated Show resolved Hide resolved
website/docs/docs/use-dbt-semantic-layer/exports.md Outdated Show resolved Hide resolved
website/docs/docs/use-dbt-semantic-layer/exports.md Outdated Show resolved Hide resolved
website/docs/docs/use-dbt-semantic-layer/exports.md Outdated Show resolved Hide resolved
website/docs/docs/use-dbt-semantic-layer/exports.md Outdated Show resolved Hide resolved
website/docs/docs/use-dbt-semantic-layer/exports.md Outdated Show resolved Hide resolved
website/docs/docs/use-dbt-semantic-layer/exports.md Outdated Show resolved Hide resolved
website/docs/docs/use-dbt-semantic-layer/exports.md Outdated Show resolved Hide resolved
website/docs/docs/use-dbt-semantic-layer/exports.md Outdated Show resolved Hide resolved
mirnawong1 and others added 14 commits February 7, 2024 16:59
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
@mirnawong1 mirnawong1 merged commit afd58ee into current Feb 7, 2024
7 checks passed
@mirnawong1 mirnawong1 deleted the sl-exports branch February 7, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs February-2024 size: large This change will more than a week to address and might require more than one person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants