Update sl-partner-integration-guide.md #4836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
github-actions
bot
added
the
size: x-small
github-actions
bot
added
size: small
mirnawong1
reviewed
Feb 1, 2024
| @@ -142,6 +148,7 @@ These are recommendations on how to evolve a Semantic Layer integration and not | |||
| * Listing available dimensions based on one or many metrics | |||
| * Querying defined metric values on their own or grouping by available dimensions | |||
| * Display metadata from [Discovery API](/docs/dbt-cloud-apis/discovery-api) and other context | |||
| * Use [saved queries](/docs/build/saved-queries) to query pre-build metrics, dimensions, and filters. Refer to the [JDBC](/docs/dbt-cloud-apis/sl-jdbc) and [GraphQL](/docs/dbt-cloud-apis/sl-graphql) APIs for syntax. | |||
There was a problem hiding this comment.
@rpourzand also added this here as integration recommendations - do you think it makes sense?
There was a problem hiding this comment.
Yeah looks great! I might tweak it slightly to read like
"Expose "Saved Queries" which are pre-built metrics, dimensions, and filters that Semantic Layer developers create for easier analysis. You can expose them in your application - refer to the JDBC and GraphQL APIs..."
mirnawong1
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
updated the bullet format and added linnks - lgtm but have an outstanding question for @rpourzand !
mirnawong1
reviewed
Feb 2, 2024
|
merging this pr now @rpourzand ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
Adding a note on saved queries to our integration guide
Checklist
Adding or removing pages (delete if not applicable):
website/sidebars.jswebsite/static/_redirectsnpm run buildto update the links that point to deleted pages