Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sl-partner-integration-guide.md #4836

Merged
merged 8 commits into from
Feb 5, 2024

Conversation

rpourzand
Copy link
Contributor

@rpourzand rpourzand commented Jan 31, 2024

What are you changing in this pull request and why?

Adding a note on saved queries to our integration guide

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to deleted pages

@rpourzand rpourzand requested a review from a team as a code owner January 31, 2024 18:54
Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 10:22am

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides labels Jan 31, 2024
@github-actions github-actions bot added the size: x-small This change will take under 3 hours to fix. label Jan 31, 2024
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Feb 1, 2024
@@ -142,6 +148,7 @@ These are recommendations on how to evolve a Semantic Layer integration and not
* Listing available dimensions based on one or many metrics
* Querying defined metric values on their own or grouping by available dimensions
* Display metadata from [Discovery API](/docs/dbt-cloud-apis/discovery-api) and other context
* Use [saved queries](/docs/build/saved-queries) to query pre-build metrics, dimensions, and filters. Refer to the [JDBC](/docs/dbt-cloud-apis/sl-jdbc) and [GraphQL](/docs/dbt-cloud-apis/sl-graphql) APIs for syntax.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpourzand also added this here as integration recommendations - do you think it makes sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks great! I might tweak it slightly to read like

"Expose "Saved Queries" which are pre-built metrics, dimensions, and filters that Semantic Layer developers create for easier analysis. You can expose them in your application - refer to the JDBC and GraphQL APIs..."

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the bullet format and added linnks - lgtm but have an outstanding question for @rpourzand !

@mirnawong1
Copy link
Contributor

merging this pr now @rpourzand !

@mirnawong1 mirnawong1 merged commit b006df1 into current Feb 5, 2024
7 checks passed
@mirnawong1 mirnawong1 deleted the rpourzand-adding-saved-queries branch February 5, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content February-2024 guides Knowledge best suited for Guides size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants