Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "Access" to Regions and IPs page #4853

Merged
merged 12 commits into from
Feb 5, 2024
Merged

Adding "Access" to Regions and IPs page #4853

merged 12 commits into from
Feb 5, 2024

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Updating the Regions and IP page to include instructions on how to login to the Cloud account. This has been a longstanding request but these changes specifically address the cell changes.

Additionally changing the name of the page and adding redirect

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to deleted pages

@matthewshaver matthewshaver requested a review from a team as a code owner February 2, 2024 16:27
Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 4:22pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address labels Feb 2, 2024
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Feb 2, 2024
{
"source": "/docs/cloud/about-cloud/regions-ip-addresses",
"destination": "/docs/cloud/about-cloud/accesss-regions-ip-addresses",
"permanent": true
Copy link
Contributor

@nghi-ly nghi-ly Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are two older redirects related to regions-ip-addresses:

i might be misremembering, was there a recent decision on how we should handle older/previous redirects for a page (eg remove them, update them, etc)?

Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing all these links! left one non-blocking question re: previous redirects on the same page. will ask in slack too.

@matthewshaver matthewshaver merged commit fff8bb9 into current Feb 5, 2024
4 checks passed
@matthewshaver matthewshaver deleted the access branch February 5, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs February-2024 size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants