Suggest >= consistently in incremental models #4971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨ |
github-actions
bot
added
content
mirnawong1
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
hey @skion great suggestion and you're right about the consistency! really appreciate you opening this pr up and looking forward to future contributions ✨!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
The current docs sometimes suggest to use
>and sometimes>=when comparing last-update date(times) in incremental models. Using>could probably lead to gaps in the dataset in certain cases, but even if not, then still safer to always suggest using>=in the documentation.Checklist
N/A