Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new indirect selection pages #4977

Merged
merged 25 commits into from
Feb 27, 2024

Conversation

runleonarun
Copy link
Collaborator

@runleonarun runleonarun commented Feb 22, 2024

closes #4773

What are you changing in this pull request and why?

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to deleted pages

@runleonarun runleonarun requested a review from a team as a code owner February 22, 2024 19:26
Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 0:00am

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Feb 22, 2024
@runleonarun runleonarun changed the title Sdding new indirect selection pages Adding new indirect selection pages Feb 22, 2024
website/dbt-versions.js Outdated Show resolved Hide resolved
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! left some comments, none are blocking

Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
@runleonarun runleonarun changed the base branch from current to jerco/flags-behavior-changes February 26, 2024 16:58
@github-actions github-actions bot added size: large This change will more than a week to address and might require more than one person and removed size: medium This change will take up to a week to address labels Feb 26, 2024
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: large This change will more than a week to address and might require more than one person labels Feb 26, 2024
runleonarun and others added 2 commits February 26, 2024 09:02
Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions in light of #4814.

But we can also make these updates later too since user configs will still be a backwards compatible option within v1.8.

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
## What are you changing in this pull request and why?

Updates the profiles.yml page to reflect the changes to global configs

## Checklist
<!--
Uncomment when publishing docs for a prerelease version of dbt:
- [ ] Add versioning components, as described in [Versioning
Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages)
- [ ] Add a note to the prerelease version [Migration
Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/docs/dbt-versions/core-upgrade)
-->
- [ ] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [ ] For [docs
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning),
review how to [version a whole
page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
and [version a block of
content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
- [ ] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."

Adding or removing pages (delete if not applicable):
- [ ] Add/remove page in `website/sidebars.js`
- [ ] Provide a unique filename for new pages
- [ ] Add an entry for deleted pages in `website/static/_redirects`
- [ ] Run link testing locally with `npm run build` to update the links
that point to deleted pages
@matthewshaver matthewshaver merged commit 1faefd2 into jerco/flags-behavior-changes Feb 27, 2024
5 checks passed
@matthewshaver matthewshaver deleted the indirect-selection4773 branch February 27, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs February-2024 size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example in profiles.yml for indirect_selection
4 participants